Fix missing in.current_cell parameter entry. #6240
Conversation
MFraters
changed the title
MFraters
changed the title
|
Oke, it looks like this is ready for review. @danieldouglas92 will add a test based on his test setup. |
|
I created a test which imposes a differential stress of 350 MPa, and a water content which varies from 0 to 1000 along the x-dimension of the model. This means that the stress/water space follows the black line shown on the figure below. The test shows that we end up with the correct fabrics, going from an A-fabric (mineral id = 1) at x=-0.5 to a B-fabric (mineral id = 2) at x=0.5, with a transition from E-fabric (mineral id = 5) to C-fabric (mineral id = 3) in between.
|
MFraters
force-pushed
the
CPO_fix_missing_in_current_cell_parameter
branch
from
634ed1c to
a7ce884
Compare
MFraters
force-pushed
the
CPO_fix_missing_in_current_cell_parameter
branch
from
a7ce884 to
9e6e137
Compare
|
I have rebased the pull request and fixed the test results and made a changelog entry. So ready for another review. |
| @@ -0,0 +1,5 @@ | |||
| Fixed: Adds current cell to material model intpust | |||
There was a problem hiding this comment.
| Fixed: Adds current cell to material model intpust | |
| Fixed: Add the current cell to the material model inputs |
| @@ -0,0 +1,5 @@ | |||
| Fixed: Adds current cell to material model intpust | |||
| in the cpo particle property to fix the Olivine: Karato | |||
| 2008 mineral type. Also added a test to test this feature. | |||
There was a problem hiding this comment.
| 2008 mineral type. Also added a test to test this feature. | |
| 2008 mineral type. Also added a test for this feature. |
in.current_cell was never filled in the material_model_inputs struct, but when a cpo particle has
Minerals = Olivine: Karato 2008it is used, leading to the crasch in #6237.This fixes #6237 for me. @danieldouglas92 could you give this a go?